Update gw_convect #6749
Open
Update gw_convect #6749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
whannah1
force-pushed
the
whannah/update-gw-convect-src
branch
from
dbc44a1
to
5c37d1b
Compare
jjbenedict
reviewed
Nov 15, 2024
|
|
||
| subroutine gw_convect_init( plev_src_wind, mfcc_in, errstring) | ||
| use ref_pres, only: pref_edge | ||
| real(r8), intent(in) :: plev_src_wind ! previously hardcoded to 70000._r8 |
There was a problem hiding this comment.
I'd add here in the comments that plev_src_wind should be in units Pa to match pref_edge. Maybe also want to mention that actual steering flow pressure level can differ from what the user requests wherever the reference pressure values differ from the actual pressure values (i.e. over mountainous terrain).
jjbenedict
requested changes
Nov 15, 2024
| <entry id="gw_convect_hdepth_min" type="real" category="gw_drag" | ||
| group="gw_drag_nl" valid_values="" > | ||
| minimum hdepth for for convective GWD spectrum lookup table | ||
| Default: 2.5 |
| real(r8), parameter :: AL = 1.0e5_r8 | ||
| ! fixed parameters (we may want to expose these in the namelist for tuning) | ||
| real(r8), parameter :: tau_avg_length = 1.0e5_r8 ! spectrum averaging length | ||
| real(r8), parameter :: heating_altitude_max = 20e3 ! max altitude to check heating (probably don't need this) |
There was a problem hiding this comment.
Add units to heating_altitude_max description. Also, 20000._r8?
| @@ -118,6 +118,11 @@ module gw_drag | |||
| ! namelist | |||
| logical :: history_amwg ! output the variables used by the AMWG diag package | |||
|
|
|||
| logical :: use_gw_convect_old ! switch to enable legacy behavior | |||
| real(r8) :: gw_convect_plev_src_wind ! reference pressure level for source wind for convective GWD | |||
There was a problem hiding this comment.
Add that gw_convect_plev_src_wind must be in units Pa.
| @@ -118,6 +118,11 @@ module gw_drag | |||
| ! namelist | |||
| logical :: history_amwg ! output the variables used by the AMWG diag package | |||
|
|
|||
| logical :: use_gw_convect_old ! switch to enable legacy behavior | |||
| real(r8) :: gw_convect_plev_src_wind ! reference pressure level for source wind for convective GWD | |||
| real(r8) :: gw_convect_hdepth_min ! minimum hdepth for for convective GWD spectrum lookup table | |||
There was a problem hiding this comment.
Add units for gw_convect_hdepth_min.
| logical :: use_gw_convect_old ! switch to enable legacy behavior | ||
| real(r8) :: gw_convect_plev_src_wind ! reference pressure level for source wind for convective GWD | ||
| real(r8) :: gw_convect_hdepth_min ! minimum hdepth for for convective GWD spectrum lookup table | ||
| real(r8) :: gw_convect_storm_speed_min ! minimum convective storm speed for convective GWD |
There was a problem hiding this comment.
Add expected units for gw_convect_storm_speed_min.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The makes several changes to the convective gravity wave methods. The primary motivation was to address a problem in gw_beres_src() where the diagnosed heating max/depth values were erroneously too low whenever the ZM heating profile included negative values (or zero) in the middle of the heating layer. Additionally, previously hard coded values were exposed as namelist values for a planned QBO tuning exercise for the QBO SciDAC project.
[BFB]